-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build FE on FE changes #11422
Build FE on FE changes #11422
Conversation
.github/workflows/gradle.yml
Outdated
needs: start-frontend-test-runner # required to start the main job when the runner is ready | ||
runs-on: ${{ needs.start-frontend-test-runner.outputs.label }} # run the job on the newly created runner | ||
timeout-minutes: 120 | ||
frontend-prepare: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I recommend combing the frontend-prepare
with the frontend-build
job into a single frontend-build
job. I don't think there is value to separating these out as jobs. This helps declutter the github actions summary & simplifies the needs
block in the stop runner job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! One minor comment before we ship!
What
Builds the :airbyte-webapp project (via gradle), when FE code changes. This was not happening since we split the builds and thus accidentally the FE unit tests (jest) was never running on any PR.